mikemccand commented on code in PR #15633:
URL: https://github.com/apache/lucene/pull/15633#discussion_r2746184650
##########
lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriter.java:
##########
@@ -57,7 +57,7 @@ private void applyDeletes(SegmentWriteState state, Fields
fields) throws IOExcep
BufferedUpdates.DeletedTerms segDeletes = state.segUpdates.deleteTerms;
FrozenBufferedUpdates.TermDocsIterator iterator =
- new FrozenBufferedUpdates.TermDocsIterator(fields, true);
+ new FrozenBufferedUpdates.TermDocsIterator(fields);
Review Comment:
Oh -- are you also removing the sorting for resolving buffered deletes to
docids? In which case we should really benchy the updates heavy case ... it
would be awesome if this could speed up the default (no bloom filter) and the
"yes bloom filter" cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
