mikemccand commented on issue #15540: URL: https://github.com/apache/lucene/issues/15540#issuecomment-3824305734
Yeah +1 @hossman -- the lenient + broken behavior now is no good. Could we, if `VectorSimilarity.COSINE` vector distance is being used, validate that the vector's length is non-zero, and throw a clear exception up front, and prevent the vector from being indexed (so index does not become corrupt)? If you are using `COSINE` you are already not caring about performance (if you did, you should pre-normalize and use `DOT_PRODUCT`), so the added cost of checking vector's length is acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
