uschindler commented on PR #15629:
URL: https://github.com/apache/lucene/pull/15629#issuecomment-3828976559

   Hi,
   I got it easily installed on Windows 11. First install uvx as described on 
install page:
   ```sh
   > powershell -ExecutionPolicy ByPass -c "irm 
https://astral.sh/uv/install.ps1 | iex"
   > uvx prek install
   ```
   
   It also installed itsself in the pre-commit hooks. Then I started testing 
it. As you know, I hate Git's command line, so I tested it with TortoiseGit --- 
and it works!
   
   First I tried to just add some whitespace at end of one file. When opening 
Tortoise's Commit window and submit it, it failed the checks and showed 
results. The only confusing thing is that the log windows shows a "Close" and 
"Abort" button at bottom. You have to press Abort to actually apply the fixes. 
If you press "close", Tortoise won't apply the fixes. This is a bit confusing, 
but not this PRs fault.
   
   When you press "abort" and then refresh the modified files list, it shows no 
changes anymore (if you only added whitespace and you can't press commit again.
   
   In a second step I actually did a real change and also added obsolete 
whitespace:
   <img width="2668" height="1285" alt="image" 
src="https://github.com/user-attachments/assets/4f12f99f-1b1a-45ff-b67f-98f241ba07a8";
 />
   
   <img width="1824" height="1317" alt="image" 
src="https://github.com/user-attachments/assets/08e41938-c65e-42b5-93c7-15f985cf6df6";
 />
   
   <img width="2667" height="1284" alt="image" 
src="https://github.com/user-attachments/assets/a983dba5-35ee-4392-90f4-06d72378041a";
 />
   
   I want not able to figure out if all changes work correctly with Windows, 
like calling astgrep works fine.
   
   I am fine with this.
   
   Only question I have is: How to run the whole checks on all files outside of 
Github? I'd like to call this also on Jenkins!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to