finnroblin commented on PR #15553: URL: https://github.com/apache/lucene/pull/15553#issuecomment-3837027362
Thanks @kaivalnp ! I've added `@lucene.internal` annotations/package-private comments as suggested and added a mergedFloatVectorValues test. Also, I added to `CHANGES.txt` under the 10.4.0 section. > This bug only affects users doing something specific during merging that skips a vector? Yes, the bugfix will allow OpenSearch k-NN to partition different parts of the vectorvalues during merging so we can upload the vectors in parallel for a GPU acceleration use case (more detail [here](https://github.com/opensearch-project/k-NN/issues/2803)). I suppose it will also affect any user who uses `nextDoc` -> delayed `vectorValue` read, but I can't think of any use cases besides partitioning a segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
