gaobinlong commented on code in PR #15656:
URL: https://github.com/apache/lucene/pull/15656#discussion_r2757326623


##########
lucene/misc/src/java/org/apache/lucene/misc/search/MemoryAccountingBitsetCollector.java:
##########
@@ -56,4 +57,8 @@ public void collect(int doc) {
   public ScoreMode scoreMode() {
     return ScoreMode.COMPLETE_NO_SCORES;
   }
+
+  public FixedBitSet getBitSet() {

Review Comment:
   We need to expose a public method for the upstream caller to get the 
collected result, but at second thought, this can be implemented in a collector 
manager for this collector, so we don't need to add a public method here, and 
the bitSet variable is protected, so we can access it directly in the test 
method. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to