ML-dev-crypto commented on issue #15661: URL: https://github.com/apache/lucene/issues/15661#issuecomment-3841628036
Hello maintainers PLEASE ASSIGN THIS ISSUE TO ME Proposed Solution The failure in TestForTooMuchCloning.test() on the 10.x branch appears to be caused by test flakiness rather than a functional regression, as the excessive IndexInput.clone() calls occur under specific randomized seeds and high test multipliers. I propose the following approach: Relax the clone-count threshold slightly in TestForTooMuchCloning for the 10.x branch to account for legitimate variability observed in CI runs, while still keeping the test effective at catching real regressions. Improve diagnostics by logging additional context (e.g., seed, multiplier, and query parameters) when the assertion fails, making future debugging easier. Validate stability by repeatedly running the test with high multipliers and multiple seeds to ensure the change eliminates flakiness without masking real issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
