dweiss commented on code in PR #15508:
URL: https://github.com/apache/lucene/pull/15508#discussion_r2792293666
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -178,9 +178,9 @@ static VectorizationProvider lookup(boolean testMode) {
}
} catch (NoSuchMethodException | IllegalAccessException e) {
throw new LinkageError(
- "PanamaVectorizationProvider is missing correctly typed
constructor", e);
+ "NativeVectorizationProvider is missing correctly typed
constructor", e);
} catch (ClassNotFoundException cnfe) {
- throw new LinkageError("PanamaVectorizationProvider is missing in
Lucene JAR file", cnfe);
+ throw new LinkageError("NativeVectorizationProvider is missing in
Lucene JAR file", cnfe);
}
Review Comment:
This will always attempt to load the native library, won't it? Maybe this
native vectorization provider should be an opt-in here (controlled by an
explicit property?), followed by the panama provider that we already have?
This addition really should have a minimum surface impact over the current
codebase because we don't have any test support for this native wrapper.
I think it'll confuse people if we start to emit
"NativeVectorizationProvider" and they don't know what it is or where to get it.
If you make it an opt-in property, you could also remove
test.native.dotProduct and use that property to enable native provider in tests
and benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
