fcofdez commented on PR #15718: URL: https://github.com/apache/lucene/pull/15718#issuecomment-3925787660
> Though looking at the behavior in IndexingChain that always calls startStoredFields, and the logic [in StoredFieldsConsumer](https://github.com/apache/lucene/blob/f12e44b6515a25933dc5e9316df72d8b093eae12/lucene/core/src/java/org/apache/lucene/index/StoredFieldsConsumer.java#L58-L61), it looks like we do require that startDocument() and finishDocument() get called for each doc. That's a bummer. Yes, I think that's a contract that we have to keep. Alternatively we could use a different approach and just write a flag in the stored fields metadata where we track that there are no stored fields, but we can still respond calls to the `#document` methods. But that seems like a deeper change than this and the remaining overhead should be low compared to all the seeks + reads that we do now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
