jainankitk commented on PR #15738:
URL: https://github.com/apache/lucene/pull/15738#issuecomment-3932423102

   > Looking at the logs, .vscode files were added intentionally to improve 
life for people using this ide. I'd leave them.
   
   Yeah, I wanted to do that initially. But, I have to make some changes to 
settings which might not make sense for others:
   
   ```
   % git diff
   diff --git a/.vscode/settings.json b/.vscode/settings.json
   index 1aab898912..082f7caccb 100644
   --- a/.vscode/settings.json
   +++ b/.vscode/settings.json
   @@ -1,6 +1,6 @@
    {
      "java.server.launchMode": "Standard",
   -  "java.import.gradle.enabled": false,
   +  "java.import.gradle.enabled": true,
      "java.import.maven.enabled": false,
      "java.jdt.ls.lombokSupport.enabled": false,
      "java.compile.nullAnalysis.mode": "disabled",
   @@ -9,5 +9,16 @@
      "java.inlayHints.parameterNames.enabled": "all",
      "java.inlayHints.parameterTypes.enabled": true,
      "java.inlayHints.variableTypes.enabled": true,
      "redhat.telemetry.enabled": false
   +  "java.configuration.runtimes": [
   +    {
   +      "name": "JavaSE-25",
   +      "path": 
"/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
   +      "default": true
   +    }
   +  ],
   +  "java.jdt.ls.java.home": 
"/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
   +  "java.import.gradle.java.home": 
"/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
   +  "gradle.java.home": 
"/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home"
    }
   ```
   
   Hence, better to ignore these altogether so every developer can maintain 
their local copy? I am assuming these files are created automatically while 
setting up the workspace initially?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to