benwtrent commented on code in PR #15741:
URL: https://github.com/apache/lucene/pull/15741#discussion_r2833988403
##########
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java:
##########
@@ -511,6 +516,18 @@ private abstract static class CompetitiveState {
abstract void update(int minOrd, int maxOrd) throws IOException;
}
+ private static class EmptyCompetitiveState extends CompetitiveState {
+
+ EmptyCompetitiveState(LeafReaderContext context) {
+ super(context);
+ }
Review Comment:
I think here, we should set `iterator.update(DocIdSetIterator.empty())` from
the get go right? The competitivestate sets it to `all` initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
