john-wagster commented on code in PR #15753:
URL: https://github.com/apache/lucene/pull/15753#discussion_r2842153942
##########
lucene/core/src/test/org/apache/lucene/util/automaton/TestAutomaton.java:
##########
@@ -1728,4 +1728,57 @@ public void testMakeCharSetDups() {
AutomatonTestUtil.assertMinimalDFA(actual);
assertTrue(AutomatonTestUtil.sameLanguage(expected, actual));
}
+
+ public void testMakeCharCaseInsensitive() {
+ Automaton a = Automata.makeChar('a', true);
+ assertTrue(Operations.run(a, "a"));
+ assertTrue(Operations.run(a, "A"));
+ assertFalse(Operations.run(a, "b"));
+
+ a = Automata.makeChar('A', true);
+ assertTrue(Operations.run(a, "a"));
+ assertTrue(Operations.run(a, "A"));
+ assertFalse(Operations.run(a, "b"));
+
+ a = Automata.makeChar('a', false);
+ Automaton b = Automata.makeChar('a');
+ assertTrue(AutomatonTestUtil.sameLanguage(a, b));
+ assertTrue(Operations.run(a, "a"));
+ assertFalse(Operations.run(a, "A"));
+
+ a = Automata.makeChar('Σ', true);
+ assertTrue(Operations.run(a, "Σ"));
+ assertTrue(Operations.run(a, "σ"));
+ assertTrue(Operations.run(a, "ς"));
+
+ // German sharp S: 'ß' (U+00DF) and 'ẞ' (U+1E9E)
+ a = Automata.makeChar(223, true);
+ assertTrue(Operations.run(a, Character.toString(223)));
+ assertTrue(Operations.run(a, Character.toString(7838)));
+
+ assertTrue(a.isDeterministic());
+ assertFalse(Operations.hasDeadStates(a));
Review Comment:
I believe I've appropriately used the correct AutomatonTestUtil functions
now. Let me know if you feel otherwise or if you think we need additional
checks as I'm only doing it on one of the Automaton for each function as a
sanity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
