mikemccand commented on issue #15520: URL: https://github.com/apache/lucene/issues/15520#issuecomment-3984051567
> I was looking at the code and we do have : [PerThreadPKLookup.java ](https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java) which is a class in tests. Oooh good find -- +1 to promote that to core. Let's rename it to at least spell out `PrimaryKey`? I'm not loving the `PerThread` prefix... maybe we name it `PrimaryKeyLookup` and javadoc and `assert` the thread stickiness? And maybe `BatchPrimaryKeyLookup` or `BulkPrimaryKeyLookup`? These would just sort the ids and delegate to `PrimaryKeyLookup` I think. And if we see that the bulk lookup is not much of a performance win, we can skip it, only offer singleton lookup? (Terms dict over time maybe doesn't care as much about ordered lookup with a single `TermsEnum`). Then, finally, we can cutover `luceneutil`'s batch `PKLookup` to Lucene's impl! Thank you for also improving the current `PKLookup` in luceneutil @shubhamsrkdev (https://github.com/mikemccand/luceneutil/pull/539). Nice to see recent benchmarking love... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
