kaivalnp commented on code in PR #15790:
URL: https://github.com/apache/lucene/pull/15790#discussion_r2891114284
##########
lucene/CHANGES.txt:
##########
@@ -113,6 +113,8 @@ Improvements
Optimizations
---------------------
+* GITHUB#15024: Improve prefix sum computation in Lucene99HnswVectorsReader
for faster neighbor decoding. (Luis Negrin)
Review Comment:
This entry is under 11.0.0 -- can you move it to 10.5.0? (I can help with
merge + backport)
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##########
@@ -560,16 +560,18 @@ public void seek(int level, int targetOrd) throws
IOException {
dataIn.seek(graphLevelNodeOffsets.get(targetIndex +
graphLevelNodeIndexOffsets[level]));
arcCount = dataIn.readVInt();
assert arcCount <= currentNeighborsBuffer.length : "too many neighbors:
" + arcCount;
+ int sum = 0;
Review Comment:
nit: Would prefer this variable inside the `if` block below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
