kaivalnp commented on PR #15784: URL: https://github.com/apache/lucene/pull/15784#issuecomment-4130085519
Thanks @msokolov @benwtrent ! The latest commit is mainly cosmetic -- adds explicit variables `DECAY_MAX_APPROXIMATION = 0` and `DECAY_MAX_QUALITY = 1` to denote the valid range of `decay` and direction of increasing result quality, adds validation for `resultSimilarity` and `decay`, and some more tests. There was a merge conflict with #15836, which short-circuited HNSW search if `traversalSimilarity = -Infinity`. In the new algorithm, this corresponds to `decay = DECAY_MAX_QUALITY`. > so switching to a "decay" thing is a BIG switch, so some nice documentation would be helpful. I added an entry under `MIGRATE.md` if that helps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
