sgup432 commented on code in PR #16050:
URL: https://github.com/apache/lucene/pull/16050#discussion_r3236509359
##########
lucene/core/src/java/org/apache/lucene/index/NumericDocValues.java:
##########
@@ -91,4 +91,38 @@ public void longValues(int size, int[] docs, long[] values,
long defaultValue)
values[i] = value;
}
}
+
+ /**
+ * Fills a {@link org.apache.lucene.util.FixedBitSet} with the doc IDs in
{@code [fromDoc, toDoc)}
+ * whose values are in {@code [minValue, maxValue]}. This is a bulk
operation that avoids per-doc
+ * virtual dispatch overhead.
+ *
+ * <p>The default implementation falls back to per-doc evaluation via {@link
#advanceExact} and
+ * {@link #longValue}. Subclasses with random-access storage (e.g., dense
fixed-bitsPerValue
+ * fields) can override this for significantly better performance.
+ *
+ * @param fromDoc first doc ID to evaluate (inclusive)
+ * @param toDoc last doc ID to evaluate (exclusive)
+ * @param minValue lower bound of the range (inclusive)
+ * @param maxValue upper bound of the range (inclusive)
+ * @param bitSet the bitset to fill
+ * @param offset subtracted from each doc ID before setting the bit
+ */
+ public void rangeIntoBitSet(
+ int fromDoc,
+ int toDoc,
+ long minValue,
+ long maxValue,
+ org.apache.lucene.util.FixedBitSet bitSet,
Review Comment:
Yeah using FixedBitSet was intentional. As @benwtrent mentioned, FixedBitSet
is the type used by all existing intoBitSet methods in Lucene which is why I
kept it like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
