uschindler commented on PR #16050: URL: https://github.com/apache/lucene/pull/16050#issuecomment-4460378448
Hi, In general, the setup of code looks fine. It is in line with other implementations. I don't know if the vectorized code works well on all CPU types. This is better known by @rmuir, maybe he can give some comments. If some CPUs or avx versions are not supported well, the provider class needs to check and fall back to the default impl. This can be done by an if statement in the code that returns the implementation. Otherwise I see no issues with the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
