gaobinlong opened a new pull request, #16078:
URL: https://github.com/apache/lucene/pull/16078

   ### Description
   
   This is a follow-up PR for https://github.com/apache/lucene/pull/15660, in 
LargeNumHitsTopDocsCollector, we should
   
   1) reject 0 and negative values for requestedHitCount in the constructor, 
that makes more sense
   2) in topDocs(int howMany) method, we should return empty TopDocs directly 
in case of howMany ==0, and return all hits if howMany> totalHitsCount, this is 
consistent with  TopDocsCollector.topDocs(int start, int 
howMany)https://github.com/apache/lucene/blob/9f33b54a13a05b2931fc798381a225b10229e704/lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java#L131
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to