romseygeek commented on PR #16069: URL: https://github.com/apache/lucene/pull/16069#issuecomment-4475860195
> one important thing I noticed is not all iterators are fast here. the default intoBitSet just loops one doc at a time and can actually be worse than advance(). so we only use this when the iterator (or the wrapped one from constant score scorer) really has a proper fast implementation. > also made sure wrappers don’t hide this. added delegation so we can still detect fast intoBitSet correctly. I'm not seeing these checks in the current PR? > this is why i added the guard, if we always use intoBitSet, slow cases like randomquery become very bad. with the guard, we just skip bitset there Which guard do you mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
