sgup432 commented on issue #16071: URL: https://github.com/apache/lucene/issues/16071#issuecomment-4489801226
I wonder if caching results of a dense field which is a primary sort of an index makes any sense. As the computation for such case is cheap as it only requires few skipper reads which should be quick considering we store the skip index in a separate file now and it would be hot in page cache. In addition, LRUCache is primarily used for expensive queries(calculated via query type, cost etc), so I think we shouldn't cache in this case? It could also evict a genuinely expensive query from the cache, so we should use the heap cache more carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
