mikemccand commented on PR #16086: URL: https://github.com/apache/lucene/pull/16086#issuecomment-4490366121
Also, since things can vary drastically depending on the env, let's use time/seconds as the "check every", not bytes? We can hardwire this to something reasonable that's surely in the noise of overall merge cost. For merges, `IndexWriter` already wraps the provided `Directory` to track which files are created for Codec file-tracking purposes, I think? If so, we could in theory wrap that to also instrument every `IndexInput` with this "check every N seconds", maybe. We should be able to make this fix (once we really understand root cause -- do any of our unit tests check for prompt merge aborts?) without having to expose another knob for Lucene users to tune ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
