kaivalnp commented on code in PR #16065:
URL: https://github.com/apache/lucene/pull/16065#discussion_r3268716227
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/faiss/FaissLibraryNativeImpl.java:
##########
@@ -140,7 +140,9 @@ private static long readBytes(
private static final Map<VectorSimilarityFunction, Integer>
FUNCTION_TO_METRIC =
Map.of(
// Mapped from faiss/MetricType.h
+ // COSINE uses METRIC_INNER_PRODUCT with normalized vectors
Review Comment:
nit: would be great to link
https://github.com/facebookresearch/faiss/wiki/FAQ#how-can-i-index-vectors-for-cosine-distance
somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
