gaobinlong commented on code in PR #15565:
URL: https://github.com/apache/lucene/pull/15565#discussion_r3279309894
##########
lucene/grouping/src/java/org/apache/lucene/search/grouping/AllGroupHeadsCollector.java:
##########
@@ -232,6 +232,20 @@ protected void setNextReader(LeafReaderContext ctx) throws
IOException {
* @throws IOException If I/O related errors occur
*/
protected abstract void updateDocHead(int doc) throws IOException;
+
+ /**
+ * Returns the sort values for this group head.
+ *
+ * @return the sort values, or null if not stored
+ */
+ protected abstract Object[] getSortValues();
+
+ /**
+ * Returns the field comparators used to determine the group head ordering.
+ *
+ * @return the comparators, one per sort field
+ */
+ protected abstract FieldComparator[] getComparators();
Review Comment:
Sure, I'll open another PR to remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
