iprithv commented on issue #16117: URL: https://github.com/apache/lucene/issues/16117#issuecomment-4530461422
before I work on this, @Tim-Brooks @ChrisHegarty tagging you as you worked on #15990. Would appreciate your input, thanks! 1. Should the methods be `updateDocuments(Term, ColumnBatch)` (overloading the existing row-oriented name) or `updateBatch(Term, ColumnBatch)` (new name matching `addBatch`)? 2. Should both `Term` and `Query` deletion variants be included, or just `Term` to start? 3. Should `softUpdateDocuments(Term, ColumnBatch, Field... softDeletes)` also be added for parity with the row-oriented `softUpdateDocuments(Term, Iterable, Field...)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
