epotyom commented on PR #15898: URL: https://github.com/apache/lucene/pull/15898#issuecomment-4536293229
Thank you for the change, nice performance improvement! Since the sandbox facets API is experimental, I wonder if we can go further and eliminate the cache entirely. What if we added a mechanism for each leaf to use its own local ordinals during collection, then remap them to global ordinals in `FacetFieldCollectorManager#reduce`? That would remove thread contention altogether rather than just reducing it. I've just opened #16122 which does ordinal remapping in reduce, but at the global level (after merging leaf data). Something similar could work for per-leaf remapping. What do you think? Alternatively, we can merge your change now and treat the API redesign as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
