neoremind commented on PR #16123: URL: https://github.com/apache/lucene/pull/16123#issuecomment-4543713681
Nice follow-up! The speedup looks solid! One minor comment, non-blocking: would it be better to move this to a method like `orMask` in `FixedBitSet`? Now it feels like leaking the internal bit manipulation outside, maybe other experts have more opinion on the inline way vs. encapsulation in `FixetBitSet`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
