romseygeek commented on code in PR #16141:
URL: https://github.com/apache/lucene/pull/16141#discussion_r3316474928
##########
lucene/core/src/java/org/apache/lucene/search/Weight.java:
##########
@@ -277,7 +281,12 @@ public int score(LeafCollector collector, Bits acceptDocs,
int min, int max)
// iterator implementations.
if (twoPhase == null && competitiveIterator == null) {
// Optimize simple iterators with collectors that can't skip
- scoreIterator(collector, acceptDocs, iterator, max);
+ if (scorer instanceof ConstantScoreScorer constantScoreScorer
Review Comment:
Instanceof checks feel a bit off to me here. I wonder if we should look at
implementing a ConstantScoreBulkScorer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
