shubhamvishu commented on code in PR #16092: URL: https://github.com/apache/lucene/pull/16092#discussion_r3336266473
########## lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsReader.java: ########## @@ -81,26 +83,40 @@ public class Lucene104ScalarQuantizedVectorsReader extends FlatVectorsReader private final IndexInput quantizedVectorData; private final FlatVectorsReader rawVectorsReader; private final Lucene104ScalarQuantizedVectorScorer vectorScorer; + private final FieldInfos fieldInfos; + + /** Lazily built Hadamard rotations, keyed by field name. */ + private final Map<String, HadamardRotation> rotations = new ConcurrentHashMap<>(); Review Comment: I made it a single global matrix (per dimension) and not maintaining it per segment now. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
