mikemccand commented on PR #15979: URL: https://github.com/apache/lucene/pull/15979#issuecomment-4682352737
> To work around this, I simply moved [this line](https://github.com/mikemccand/luceneutil/blob/c530a720329bba774fefdadd17e027187845d100/src/main/knn/KnnIndexer.java#L257) to after `waitForMergesWithStatus` to include both (1) and (2) in `index(s)`. > > Can we look at the sum of `index(s)` and `force_merge(s)` as a "total indexing time" proxy? Oh no, I missed this first time around. Yeah this is difficult -- I'd rather keep "indexing time" as it is (after the final commit) because one could rollback at that point (presumably quickly) and have an accurate/intact index. Can we add 2nd time measure, which is time to wait for the in-flight merges? And, I would rather not pay much attention to either merge time in our comparisons here -- merge timing is exceptionally noisy, and has discrete step changes (a force-merge that needs two rounds vs three rounds for example). The only way to compare merge time would be single thread running force merge on same geometry index. Maybe open upstream (`luceneutil`) issue about this @kaivalnp? Sorry the the slow response! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
