vijaykriishna commented on code in PR #16207: URL: https://github.com/apache/lucene/pull/16207#discussion_r3409404786
########## lucene/core.tests/src/test/org/apache/lucene/core/tests/util/hnsw/TestBlockingFloatHeap.java: ########## @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.core.tests.util.hnsw; + +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.BrokenBarrierException; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.CyclicBarrier; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.lucene.tests.util.LuceneTestCase; +import org.apache.lucene.util.hnsw.BlockingFloatHeap; + +/** + * Unit tests for {@link BlockingFloatHeap} with focus on thread-safety and data race conditions. + */ +public class TestBlockingFloatHeap extends LuceneTestCase { Review Comment: > I see more things here, which doesn't test this bug except testDataRaceOnPoll...other things i dont think other tests fail without the fix, we can keep testDataRaceOnPoll and remove others? You're right. testDataRaceOnPoll() is the only test that specifically reproduces the race fixed in this change. The other tests are broader concurrency checks and don't appear to fail without the fix. I've removed them and kept only testDataRaceOnPoll(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
