iprithv commented on code in PR #16264:
URL: https://github.com/apache/lucene/pull/16264#discussion_r3422687506
##########
lucene/core/src/java/org/apache/lucene/index/MergeState.java:
##########
@@ -91,14 +91,22 @@ public class MergeState {
/** Indicates if the index needs to be sorted * */
public boolean needsIndexSort;
+ /**
+ * The merge that this state is associated with, or {@code null} if this
merge state is not
+ * associated with an {@link IndexWriter} merge (e.g. for addIndexes).
+ */
+ public final MergePolicy.OneMerge oneMerge;
Review Comment:
oneMerge is public, do we really want to expose the raw OneMerge on
MergeState's public API? checkAborted() method is all the codecs need, and
that's already public..making the field package-private (or at least
@lucene.internal) would avoid leaking merge internals to custom codec
implementations!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
