slow-J opened a new issue, #16267:
URL: https://github.com/apache/lucene/issues/16267
### Description
A recent Explanation change I done, #16229 has led me to some more
explanation improvements.
Bit of a WIP issues, I'll edit this comment when I get some more time.
I am thinking of looking at the following:
1. Testing gap in testExplainFailingOptionalClauses. It only asserts on the
failingOptionals list, not the main subs list. Adding a `subs.clear()` into
BooleanWeight doesn't fail any tests.
2. CheckHits.checkNoMatchExplanations is shallow. It only checks the root
explanation's isMatch() == false and never looks at its sub-details. Nested
non-match sub-explanations are never structurally verified.
3. Improve the KNN explain message. When testing #16229, we saw some unclear
output, see below.
```
0.0 = no match on optional clause
(track(knn=DocAndScoreQuery[1404635,...][0.7655482,...],0.7655482))
0.0 = not in top 1 docs
```
4. TestComplexExplanations has a long-standing `// :TODO: we really need
more crazy complex cases.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
