sgup432 commented on code in PR #16283: URL: https://github.com/apache/lucene/pull/16283#discussion_r3455685482
########## lucene/core/src/java/org/apache/lucene/internal/vectorization/SortedNumericDocValuesRangeSupport.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.internal.vectorization; + +import org.apache.lucene.util.FixedBitSet; +import org.apache.lucene.util.LongValues; + +/** + * Interface for fixed-cardinality sorted-numeric doc values range operations. + * + * @lucene.internal + */ +public interface SortedNumericDocValuesRangeSupport { Review Comment: I don't think creating a separate interface for this specific use case looks right. It differs from the existing `DocValuesRangeSupport` only by a single parameter ie `cardinality`. So doesn't justify creating a new abstraction layer just based on that, probably we can create or add just another method to existing `DocValuesRangeSupport`? Something like: ``` default void rangeIntoBitSet(LongValues values, int fromDoc, int toDoc, int cardinality, long minValue, long maxValue, FixedBitSet bitSet, int offset) { // default to scalar approach. } ``` Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
