slow-J commented on code in PR #16268:
URL: https://github.com/apache/lucene/pull/16268#discussion_r3519746228
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java:
##########
@@ -124,6 +152,39 @@ public static LongRangeFacetCutter create(
*/
abstract List<InclusiveRange> buildElementaryIntervals();
+ /**
+ * Returns the {@link DocValuesSkipper} for {@link #skipField} in this
segment. Null when: no skip
+ * field is configured, the field has no skip index, or some doc in this
segment has more than one
+ * value.
+ */
+ final DocValuesSkipper maybeSkipper(LeafReaderContext context) throws
IOException {
+ if (skipField == null) {
+ return null;
+ }
+ SortedNumericDocValues sortedNumeric =
DocValues.getSortedNumeric(context.reader(), skipField);
+ if (DocValues.unwrapSingleton(sortedNumeric) == null) {
+ return null;
+ }
+ return context.reader().getDocValuesSkipper(skipField);
+ }
+
+ /** Single-valued {@link LongValues} for {@link #skipField} in this segment.
*/
+ final LongValues skipFieldValues(LeafReaderContext context) throws
IOException {
Review Comment:
There is less of an uplift in the multivalued, compared to single valued.
│ MedTermLastModMultiOvlpRangeFacets │ 3.49 │ 3.95 │ +13.2% │
0.000 │
│ BrowseLastModMultiRangeFacets │ 1.78 │ 1.85 │ +3.8% │
0.006 │
│ BrowseLastModMultiOvlpRangeFacets │ 1.12 │ 1.15 │ +2.8% │
0.056 │
│ MedTermLastModMultiRangeFacets │ 4.51 │ 4.49 │ −0.3% │
0.849 │
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
