uschindler commented on PR #16381: URL: https://github.com/apache/lucene/pull/16381#issuecomment-4925963871
I am not so happy with that change as it makes everything more complex. It may be 2.6 times faster for each lookup, but the overall speedup during indexing is likely much lower. In addition to me the whole thing may be better organized if the optimization would be inside CharArrayMap and CharArraySet - so instead of hashing it could cast the prefix characters inside CharArraySet and use that one as lookup key. So: Wouldn't it be better to implement CharArrayMap using LongHashMap when all keys are short and ASCII only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
