Pulkitg64 commented on code in PR #16383:
URL: https://github.com/apache/lucene/pull/16383#discussion_r3596078240
##########
lucene/core/src/test/org/apache/lucene/search/TestVectorScorer.java:
##########
@@ -48,6 +50,10 @@ public void testFindAll() throws IOException {
case BYTE:
vectorScorer =
context.reader().getByteVectorValues("field").scorer(new byte[] {1, 2});
break;
+ case FLOAT16:
+ Float16VectorValues val =
context.reader().getFloat16VectorValues("field");
+ vectorScorer = val.scorer(new short[] {1, 2});
+ break;
Review Comment:
thanks for noticing, fixed it.
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene102/Lucene102BinaryFlatVectorsScorer.java:
##########
@@ -94,6 +94,13 @@ public RandomVectorScorer getRandomVectorScorer(
return nonQuantizedDelegate.getRandomVectorScorer(similarityFunction,
vectorValues, target);
}
+ @Override
+ public RandomVectorScorer getRandomVectorScorer(
+ VectorSimilarityFunction similarityFunction, KnnVectorValues
vectorValues, short[] target)
+ throws IOException {
+ return null;
Review Comment:
Fixed in next revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
