jeho-rpls commented on PR #16403: URL: https://github.com/apache/lucene/pull/16403#issuecomment-5020211971
@msokolov Agreed on the scope. One thought on "fixing on main": main does not have this bug. Since #14097 the per-field wrapper implements `HnswGraphProvider` and delegates `getGraph`, so the guard passes and reuse triggers there. I verified this by running the same reuse assertion test on unmodified main, and it passes. That is why this PR targets `branch_10x` directly. In my view, what main is missing is a test asserting that reuse actually triggers. I can open a small test-only PR against main with the same test. Does that sound useful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
