sgup432 commented on PR #15558: URL: https://github.com/apache/lucene/pull/15558#issuecomment-5027277004
>Were we able to back port it to 10.x? I don't think I see these changes in 10.5? No, we didn't backport it to 10.x. I think it was a conscious choice as the query cache re-implementation introduced some breaking changes. For example onQueryCache/eviction methods in this cache have been deprecated and new methods have been introduced. They still work but won't report accurate data. This was done as query cache <key, value> structure was changed, and we don't track unique queries anymore. Along with it, we also changed the cleanup logic of the cache from sync to async flow using a background thread. Note that this cleanup logic is around removing stale segment entries from the cache. Earlier it was done as soon as the segment got stale, now we collect those stale segment entries and clean up them later with a background thread. With this, user can either do this manually by calling cleanup() method whenever they want or pass a executor service to configure this cleanup at a specified interval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
