serhiy-bzhezytskyy commented on PR #12872: URL: https://github.com/apache/lucene/pull/12872#issuecomment-5158402613
This PR looks stalled — no longer mergeable, and the last comment from a human is from February 2024 — but the problem it fixes is still there, so I have carried it forward in #16476 rather than let it sit. Your commit is the first one there, rebased onto `main` with your authorship intact, and you are credited in `CHANGES.txt`. Two hunks needed adjusting: `codec.segmentInfoFormat().read(...)` now takes `IOContext.READONCE` on `main`, and the wildcard import had to go back to explicit ones for the ecj lint. `CheckIndex.java` and `TestTransactions.java` merged cleanly. On top of it I finished the two review points from this thread that the current diff does not cover: - The root cause was being dropped. `CorruptSegmentInfoException` has a constructor taking a `Throwable cause`, but the throw site calls the three-argument one — and that cause is the only thing naming the file (`NoSuchFileException` with the full path for a deleted `.si`, a suppressed `EOFException` naming the `MemorySegmentIndexInput` for a truncated one). It is passed now, and the catch is `Exception | AssertionError` per @mikemccand's comment about exotic exceptions. - `segmentName` was package-private with no accessor, so nothing outside `org.apache.lucene.index` could read the name the exception exists to carry, and no test could assert on it. There is a `getSegmentName()` now, and a test covering a deleted and a truncated `.si`. @gokaai if you would rather finish it here, say so and I will close #16476 — the point is the fix landing, not where. The `exorciseIndex` half that you deferred is #16474. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
