epotyom commented on PR #16089: URL: https://github.com/apache/lucene/pull/16089#issuecomment-5239002045
The code LGTM, thanks @kkewwei! It would still be great if you could run the luceneutil benchmarks to report wins. The README ( https://github.com/mikemccand/luceneutil/blob/main/README.md ) has all the details on how to set them up and run them, but feel free to ask me if anything's unclear. If I'm not mistaken, the "IntNRQ" task category creates a 1-dimensional PointRangeQuery, but I'm not sure the ranges these tasks use (see this task file for example: https://github.com/mikemccand/luceneutil/blob/ae1d259a4cc97a4864294932607c610c2355b16f/tasks/wikimedium.10M.tasks#L1585) are wide enough to trigger the eager bit-set upgrade path. You may need to add a new task category with a wider range, either locally or by contributing it to luceneutil. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
