mikemccand commented on code in PR #16499:
URL: https://github.com/apache/lucene/pull/16499#discussion_r3759552087
##########
lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java:
##########
@@ -428,7 +418,7 @@ public int addByPoolOffset(int offset) {
}
/**
- * Called when hash is too small ({@code > 50%} occupied) or too large
({@code < 20%} occupied).
+ * Called when hash is too small ({@code > 50%} occupied) or too large
({@code < 25%} occupied).
Review Comment:
Do we ever shrink the table while it still has elements? I think we only do
that in `clear()`? So maybe remove the `and too large` in this javadoc? We
only ever call `rehash` on growing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
