tballison opened a new pull request, #16513: URL: https://github.com/apache/lucene/pull/16513
Adds `docIDRunEnd()` contract tests to `BaseDocValuesFormatTestCase`, so every doc-values format - including custom formats outside this repo that subclass it - is automatically checked against the contract that bulk scorers rely on: every doc in a reported run [docID, docIDRunEnd()) must be a true match. For each skip-indexed DV type (numeric, sorted-numeric, sorted, sorted-set range, and sorted-set ordinal set — the non-contiguous shape from https://github.com/apache/lucene/pull/16450), the test indexes a random field (random or clustered value layout, random gaps, random doc counts), builds the corresponding DocValuesRangeIterator directly, and walks it, verifying at every position: the reported run contains only docs that a brute-force per-doc value check confirms, docIDRunEnd() does not move the approximation, and outside runs matches() agrees with brute force. I manually confirmed that these fail the pre-fix commit for PR 16450 (c93628f669, branch_10x). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
