luizmlima commented on PR #16416: URL: https://github.com/apache/lucene/pull/16416#issuecomment-5344550364
Hi @zhaih , sorry for the ping. I noticed that you've previously reviewed and merged changes in the Kuromoji module, so I thought you might be a good person to ask for feedback on this PR. This change replaces the `ArrayList` currently used as a FIFO buffer in `JapaneseCompletionFilter.CompletionTokenGenerator` with an `ArrayDeque`, avoiding `remove(0)` and using `addLast()` / `removeFirst()` instead. I've also added JMH benchmark results and additional validation details to the PR. The change does not affect the public API or the generated tokens, ordering, offsets, or position increments. If you have a chance to take a look, I'd really appreciate your feedback on whether this change makes sense for Lucene. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
