gaobinlong opened a new pull request, #16548: URL: https://github.com/apache/lucene/pull/16548
### Description Resolve a [TODO](https://github.com/apache/lucene/blob/d85fc27bb36be862130a602984f5c7e244503457/lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollector.java#L143) in TopGroupsCollector. Add `exactTotalHitsPerGroup` parameter to `TopGroupsCollector` and `TopGroupsCollectorManager`. When set to `false`, per-group hit counts may be reported as `TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO` once `maxDocsPerGroup` hits have been collected, saving the cost of exact counting. Defaults to `true` (exact counts). Benchark on wikimedium1m: TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value TermGroup100 109.06 (29.0%) 110.12 (31.7%) 1.0% ( -46% - 86%) 0.903 TermGroup1M 83.43 (21.7%) 85.24 (21.9%) 2.2% ( -34% - 58%) 0.705 TermGroup10K 119.36 (11.6%) 123.38 (12.0%) 3.4% ( -18% - 30%) 0.277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
