dweiss commented on PR #16543: URL: https://github.com/apache/lucene/pull/16543#issuecomment-5455452575
> I've sorta know someone at Gradle who works with the ASF and I crafted an email to make a case that this matter needs attention/priority it's hasn't been getting. Thanks! I definitely think this is something of value. > Neo takes actual gradle wrapper source, which is why. I prefer "lean" but if we don't maintain it then I'm indifferent. I prefer the burden of maintaining that 500 lines of code I've reviewed than reviewing updates to neo, to be honest... I'm not against it but let's wait and see what evolves - maybe gradle folks will add something of their own, maybe neo get more traction in the community. For now, I suggest to either accept this patch as is or reshape the code to use a (property) file in the user's home directory instead of env variables. I don't quite see the value of their regexp replacements - I think an URL with those replaceable gradleVersion is more consistent with what gradle wrapper does and more intuitive and I'd stick to it. The remaining logic seems very similar and there's not much to borrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
