NextbrickInc commented on PR #16542: URL: https://github.com/apache/lucene/pull/16542#issuecomment-5465587868
@jimczi — both items you flagged as blocking are in 8161b4f. The four-argument constructor is gone; ScoreMode is explicit at all 45 call sites, including ReadAheadMatchAllDocsQuery, which now passes the scoreMode it already held two lines above — the exact next-caller bug you predicted. The flaky deletions test. Your diagnosis was right. Both deletion tests use a plain IndexWriter and assert reader.hasDeletions(). -Ptests.seed=14471C5085979DA7 passes, as does the full :lucene:core:test on that seed. To show the coverage is genuinely back rather than merely green: with the guard disabled, testConstantScoreQueriesWithDeletionsUnderComplete now fails 30/30 at 4095/19999, where before it depended on the doRandomForceMerge() coin flip. Trimming per your note: 14 tests → 10, suite 8.5s → 1.6s. With the guard disabled the same five tests you identified still fail, so nothing was lost. One I should have caught before you saw it: beasting found that this PR introduced a flake into TestMultiCollector. I'd changed newSearcher(reader, false, false, false) to true, true, true; the third argument is wrapWithAssertions, and that test deliberately violates the setMinCompetitiveScore contract, so AssertingScorer fires whenever the random draw produces an AssertingIndexSearcher. Both call sites now use true, false, true — keeping the reader wrapping and concurrency, dropping only the assertion wrapping. Clean at 500 and 400 iterations and under -Ptests.nightly=true; 22 failures before the fix. The AssertingScorer invariant itself is left untouched — relaxing "only TOP_SCORES may call setMinCompetitiveScore" is a contract change that belongs in its own issue, not this one. Nothing outstanding on my side. Please approve and merge when you're happy. Thanks alot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
