uschindler commented on PR #16583: URL: https://github.com/apache/lucene/pull/16583#issuecomment-5476822097
> For things like "don't make unnecessary emoji, tests, comments", all that kinda stuff probably belongs in AGENTS.md IMO, not here. > > This file is for human contributor. I'm already concerned it has a near-zero chance of actually ever getting merged, so we should try to keep the concerns separate to simplify the situation. Just my opinion That's all fine. I just wanted to add my findings when reviewing PRs. Actually some emojis are also coming from persons (not sure which culture encourages that, maybe also because of AI suggest and they copy AI's behaviour). As said, some Emojis were in PR descriptions which were heavily human written (because of typos), but still had those empojis. Therefor I suggested to add this somewhere. But yes, an AGENTS.md would be fine, too. Best would be an AGENTS.md saying "stay away and f*ck yourself". I think nobody has something against this PR, lets get in in after maybe 72 hours of waiting time. I will do the same for my SECURITY.md file (see other PR you already reviewed). Uwe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
