ethbak commented on issue #16618: URL: https://github.com/apache/lucene/issues/16618#issuecomment-5515648551
Pulling the data from the previous benchmark runs, I see the following: | delete % | F flagged for repair | reuse/rebuild CPU | reuse/rebuild wall | |---|--:|--:|--:| | 10% | 28,410 | 0.85 (~15% less CPU) | 1.10× wall | | 35% | 66,990 | 0.94 (~6% less CPU) | 1.79× wall | So, CPU use decreases with the optimization as we would expect. I agree that this issue is not one of correctness but of performance. It's great to see the re-use optimization is now working (mostly) as expected to reduce CPU constraint, but parallelizing repair will give us the speedup that the original PR had advertised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
