dweiss commented on PR #16592: URL: https://github.com/apache/lucene/pull/16592#issuecomment-5536747308
Thank you, Robert. It is a large patch and I took a lot of manual steps to review it manually in some logical parts - mostly by diffing corresponding fragments against main, where we know it works, but also by testing the final output (distribution zip) for regressions. Even though the code is mostly ported with an LLM, I am confident it is a good set of changes and it works fine. I will merge tonight if there are no other voices against it. There are some follow ups we could do then which would be smaller - ICU upgrades, snowball, etc. don't know if they should land on 10x for back compat reasons but this patch makes it definitely easier to backpprt them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
