msfroh commented on PR #16657: URL: https://github.com/apache/lucene/pull/16657#issuecomment-5626616110
Hmm... since eviction is managed on a per-partition basis, I don't think we can reasonably pull `uniqueQueries` up to the root, since we won't know when things should be evicted. Actually, looking at the implementation, I'm not convinced that we are properly accounting for query size in ramBytesUsed, since the cache entries are on the segment/query pairs. But we increment the query size contribution for each entry, even though it's probably the same query instance. I agree that this change fixes the immediate bug, but I'm worried that there are other issues with the new cache implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
