ColinLeeo commented on issue #15840: URL: https://github.com/apache/lucene/issues/15840#issuecomment-5629541468
Hi, I’d like to help with this issue. After looking through `NativeVectorUtilSupport`, I think there are two layers of behavior we may want to test. The first is the Java-side logic: native versus fallback dispatch, argument handling, and result handling. This could potentially be tested by making the symbol lookup or method handles injectable and providing Java-backed test implementations. The second is the end-to-end native integration path, including `System.loadLibrary`, symbol lookup, and FFM downcalls. Covering this path would probably require a small test-only C library and a forked JVM. Before implementing the tests, I think we should also document the ABI semantics of each native function, especially whether the length argument represents bytes, elements, or an upper bound. I would suggest starting with a small Java-side test covering `dotProduct` and fallback behavior, and then adding a minimal native smoke test separately if real library-loading and ABI coverage is needed. Does this split match the intended scope of the issue? For the first PR, would you prefer to focus on the Java-side behavior, the real native ABI path, or both? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
